commit 5d590dd66860c99d1aac0a6208d34e2902100de3
parent 032cfa39915f46985c11ad4af7f174f2788400bb
Author: kyle <kyle@getaddrinfo.net>
Date: Sat, 21 Nov 2015 19:34:44 -0700
tests: repurpose new_list_bad_devid
- before this test would only send a bad device id for the new_list message
- now it sends bad device id's to all messages that take device id
Diffstat:
6 files changed, 25 insertions(+), 17 deletions(-)
diff --git a/tests/new_list_bad_devid/Makefile b/tests/bad_deviceid/Makefile
diff --git a/tests/bad_deviceid/server.log.good b/tests/bad_deviceid/server.log.good
@@ -0,0 +1,9 @@
+new connection
+unknown device <base64>
+unknown device <base64>
+unknown device <base64>
+unknown device <base64>
+unknown device <base64>
+unknown device <base64>
+unknown device <base64>
+disconnected!
diff --git a/tests/bad_deviceid/test.pl b/tests/bad_deviceid/test.pl
@@ -0,0 +1,15 @@
+#!/usr/bin/perl -I../
+use strict;
+use warnings;
+use test;
+
+# this test:
+# - tries to send every message type with an invalid id
+# - except for new_device message type
+
+my $sock = new_socket();
+for my $msg (sort @msg_str) {
+ # new device doesn't take device id as a first parameter
+ next if ($msg eq "new_device");
+ send_msg($sock, $msg_num{$msg}, "notvaliddeviceid");
+}
diff --git a/tests/new_list_bad_devid/server.log.good b/tests/new_list_bad_devid/server.log.good
@@ -1,3 +0,0 @@
-new connection
-unknown device <base64>
-disconnected!
diff --git a/tests/new_list_bad_devid/test.pl b/tests/new_list_bad_devid/test.pl
@@ -1,13 +0,0 @@
-#!/usr/bin/perl -I../
-
-use strict;
-use warnings;
-
-use test;
-
-# this test:
-# - gets a new device id
-# - tries to create a new list with and invalid device id
-
-my $sock = new_socket();
-send_msg($sock, 1, "a\0some list over here");
diff --git a/tests/test.pm b/tests/test.pm
@@ -8,7 +8,7 @@ use IO::Socket;
require "msgs.pl";
our (%msg_num, @msg_str, @msg_func, $protocol_ver);
-our @EXPORT = qw(new_socket fail send_msg recv_msg %msg_num);
+our @EXPORT = qw(new_socket fail send_msg recv_msg %msg_num @msg_str);
sub fail {
print shift;