commit e2183f6b8427f9aa5b6bd3d595e5418d8933cc36 parent 97e1a0947aa2f4c2e6bd8d73011afdd1db4b9a9c Author: Kyle Milz <kyle@getaddrinfo.net> Date: Sun, 15 Mar 2015 22:09:46 -0600 price_scraper: be more strict when validating input Diffstat:
| M | price_scraper | | | 17 | ++++++++--------- |
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/price_scraper b/price_scraper @@ -145,26 +145,25 @@ sub get_valid_price my $num_prices = @search_prices; return undef if ($num_prices == 0); - print "info: $vendor: $dom_tag ($num_prices)\n" if ($args{v}); + print "info: $vendor: $dom_tag: $num_prices elements\n" if ($args{v}); + my $hdr = "$vendor: $dom_tag" . "[0]"; # do a fuzzy search for digit combinations that look like a price # XXX: uses the first found price in the page # XXX: this does not work on single digit prices, ie $7.00 my ($price, @others) = ($search_prices[0] =~ m/(\d[\d,]+)/); - return undef unless defined $price; - - # print total regex matches we had above - $num_prices = @others + 1; - print "info: $vendor: $dom_tag" . "[0] ($num_prices)\n" if ($args{v}); - return undef if (@others); + if (!defined $price && @others) { + print $log "error: $hdr: wrong number of regexs\n"; + return undef; + } # sanity check the numerical price value $price =~ s/,//; if ($price <= 0 || $price > 10000) { - print $log "error: $vendor: price $price out of range\n"; + print $log "error: $hdr: price $price out of range\n"; return undef; } - print "info: $vendor: $dom_tag" . "[0]: \$$price\n" if ($args{v}); + print "info: $hdr: \$$price\n" if ($args{v}); return $price; }